cio

commit 11f1f2d8fd56694a131658e06ac5e94465ece368
parent 11a1e3f6c9254fd7f188166617ed9ac0fa64ce50
Author: Andrew Kloet <andrew@kloet.net>
Date:   Sat,  2 May 2026 12:02:11 -0400

scmd: be more obvious about case behaviour

Diffstat:
M
cio.c
 | 
23
+++++++++++------------

1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/cio.c b/cio.c
@@ -442,7 +442,7 @@ scmd(char *usr, char *cmd, int argc, char **argv)
 		if (bang) *bang = '\0';
 	}
 	switch (type) {
-	case NOTICE:
+	case NOTICE: /* FALLTHROUGH */
 	case PRIVMSG:
 		if (argc < 2) break;
 		char *chan;
@@ -467,12 +467,6 @@ scmd(char *usr, char *cmd, int argc, char **argv)
 		else
 			sndf("PONG :%s", chl[0]);
 		break;
-	case PONG:
-	case JOIN:
-	case PART:
-		break;
-	case QUIT:
-		break;
 	case NICK:
 		if (argc < 1) break;
 		if (!strcasecmp(usr, nick)) {
@@ -487,10 +481,7 @@ scmd(char *usr, char *cmd, int argc, char **argv)
 	case RPL_NAMREPLY:
 		if (argc >= 4) pushf(chfind(argv[2]), "-!- Names: %s", argv[3]);
 		break;
-	case RPL_TOPICWHOTIME:
-	case RPL_ENDOFNAMES:
-		break;
-	case ERR_NOCHANMODES:
+	case ERR_NOCHANMODES: /* FALLTHROUGH */
 	case ERR_CHANNELISFULL:
 	case ERR_INVITEONLYCHAN:
 	case ERR_BADCHANNELKEY:
@@ -534,12 +525,20 @@ scmd(char *usr, char *cmd, int argc, char **argv)
 			sndf("AUTHENTICATE %s", b64);
 		}
 		break;
-	case SASL_OK:
+	case SASL_OK: /* FALLTHROUGH */
 	case SASL_ERR:
 		sndf("CAP END");
 		pushf(0, "-!- SASL auth %s",
 		    (type == SASL_OK ? "successful" : "failed"));
 		break;
+	/* Ignored commands */
+	case PONG: /* FALLTHROUGH */
+	case JOIN:
+	case PART:
+	case QUIT:
+	case RPL_TOPICWHOTIME:
+	case RPL_ENDOFNAMES:
+		break;
 	default: {
 		if (!isdigit(cmd[0])) break;
 		char arg_buf[LineLen] = "";